Repository navigation
Conversation
…_of_the_kit_needs_more_than_ci_has` deterministic The tests come first and fail until the implementation. The test runs the CI-runnability guard over the whole tests tree: `check_tests()` in `tests/ci_runnable.py` calls `check_modules` (`tests/wide_scans.py`), which takes every `test_*.py` under `tests/`… Done when every test listed below carries the loaded limit, the CI-runnability guard parses only modules whose text contains `integration`, the guard's logic tests and its baseline are unchanged, and… Unit: fix-test-tests-test-ci-runnable-guard-py-test-no-integration-dcc32e38/1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start here
Already verified by the pipeline
Review tier:
full— the planned estimate is fullWhy
The test runs the CI-runnability guard over the whole tests tree:
check_tests()intests/ci_runnable.pycallscheck_modules(tests/wide_scans.py), which takes everytest_*.pyundertests/(root.rglob), reads it andparses it with
ast.parse. For every test that carries theintegrationselector,_violatorsthen follows thetest's same-module fixtures and helpers (
_reached) and callsAgentStart.of_function(function, tree)for each… The full reason is in
openspec/changes/fix-test-tests-test-ci-runnable-guard-py-test-no-integration-dcc32e38/proposal.md.What this pull request does
Done when every test listed below carries the loaded limit, the CI-runnability guard parses only modules whose text contains
integration, the guard's logic tests and its baseline are unchanged, and the changed tests pass under the repeat check.Makes the whole-repository guard scans in the test suite finish within their time limit under load, by giving them the loaded time limit and having the CI-runnability guard skip modules that cannot hold an integration-marked test.
tests/ci_runnable.py) no longer parses a test module whose text does not containintegration, since such a module cannot carry the selector the guard checks; its docstring says so.test_no_integration_test_of_the_kit_needs_more_than_ci_hasruns with the loaded time limit (LOADED_TEST_TIME_LIMIT) instead of the default.Based on
main, with nothing unmerged beneath it — ready to merge whenever the checks look right.Unit
fix-test-tests-test-ci-runnable-guard-py-test-no-integration-dcc32e38/1of change fix-test-tests-test-ci-runnable-guard-py-test-no-integration-dcc32e38, task group(s) 1.Spec:
openspec/changes/fix-test-tests-test-ci-runnable-guard-py-test-no-integration-dcc32e38/in the planning repo.Assumptions
This unit assumes nothing unmerged: everything it builds on is already in
main.Verification
This is a unit-test unit: everything it needs is fakes, fixtures or throwaway containers, so GitHub Actions runs the whole of it. No e2e-test run was required.
How this was built
The commit order is checked mechanically; lint, formatting and types pass at the tip.
Opened by the spec-driven pipeline. The build agent never merges. The pipeline merges only
a unit review classified
autoand policy allowed; a person merges any other, after checkingthe stack order above.